On Mon, 16 Nov 2020 04:50:13 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Hi Robbin, > > Please see the bug report for more discussion. > > Bottom line: I now agree this is the right kind of fix for this situation. I > could nit pick on the variable naming but lets just get this done. > > Thanks for your patience on this. It is important to fully understand how > these situations can arise. > > David Thanks, great! I will wait for at least acknowledge from @sspitsyn. > test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetCurrentContendedMonitor/contmon001.java > line 67: > >> 65: public static int run(String argv[], PrintStream ref) { >> 66: out = ref; >> 67: doSleep(); // If we need to load any classes to execute >> doSleep(), do it now. > > Well intentioned but not really useful. The classes used on the normal > execution path are already loaded during VM initialization. The exceptional > paths can still lead to class loading/linking/synchronization, so this > preemptive call doesn't help that case anyway. I can remove the 'dummy' calls in each test? ------------- PR: https://git.openjdk.java.net/jdk/pull/1177