On Tue, 1 Dec 2020 01:16:11 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Please review this change to obsolete the deprecated and aliased Trace >> flags. The now empty aliased_logging_flags support was left in >> arguments.cpp for use by trace flags that get deprecated and aliased in the >> future. >> >> With this change, users will get the following example messages when using >> these obsolete flags, depending on whether -XX:+... or -XX:-... was >> specified: >> >> VM warning: Ignoring option TraceClassPaths; support was removed in 16.0. >> Please use -Xlog:class+path=info instead. >> >> VM warning: Ignoring option TraceClassPaths; support was removed in 16.0. >> Please use -Xlog:class+path=off instead. >> >> The change was tested with tiers1and 2 on Linux, Windows, and MacOS, and >> tiers 3-5 on Linux x64 and with JCK lang and vm tests. >> >> Thanks, Harold > > Hi Harold, > I don't think we need to add all this new infrastructure for obsolete-aliased > flags just so we can continue to print the -Xlog equivalents. I think simply > adding these previously aliased flags as obsolete flags in the special flags > table would suffice. > Thanks, > David I should clarify this. I suggested in the bug report that we could continue to print the -Xlog equivalents, but when I wrote that I was thinking that the existing deprecated-aliased code would simply be changed to obsoleted-aliased code. I didn't consider that we might need to keep the deprecated-aliased code for future conversions to UL. But I can see now that we might want to do that. In which case I'd prefer to no longer print the -Xlog equivalents, rather than duplicate the deprecated-aliased code into an obsolete-aliased form. My intent was to get rid of this special aliased flag handling code in the near future. Thanks, David ------------- PR: https://git.openjdk.java.net/jdk/pull/1525
