On Wed, 2 Dec 2020 02:01:41 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into mprotect
>> - Made resexhaused001.004 manual tests. You can't reliably run these tests.
>> - 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64
>
> I'm okay with the functional change here, to do vm_exit_oom when guard page
> creation fails.
>
> I'm not sure about the test change. It was only problem-listed on Linux but
> now is "manual" on all platforms and so will now be excluded from automated
> testing on all platforms.
// Check platform here (instead of @requires) as this test is also called from
resexhausted004
if (Platform.isWindows()) {
throw new SkippedException("Cannot get
JVMTI_RESOURCE_EXHAUSTED_THREADS on Windows");
}
The test is programmatically excluded on windows. There's also bug
https://bugs.openjdk.java.net/browse/JDK-8244640 which shows that the
uncommit_memory() sort of works on windows, but then stack overflow handling is
then incorrect.
This test, and test resexhausted004 are useful for testing
JVMTI_RESOURCE_EXHAUSTED_THREADS, but not as part of our test system since it
fails periodically for at least the last 10 years.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1540
