On Fri, 11 Dec 2020 18:06:08 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Please update @bug in the tests to include this bug ID. >> >> All InheritAgentXXX tests are updated to have the InheritAgentXXX class >> public. However, I think you need to go through them individually for this >> behavioral change. The existing comments may not be applicable and please >> update them where appropriate. For example InheritAgent0100 previously >> verifies the invocation of the premain in its superclass. Does the modified >> test ensure that this fails to load? Per the comment in the new >> InheritAgent0100Super class, it expects the superclass' premain should be >> called. > > Mandy, thank you for comments. > You are right, the comments at 429-443 and tests need some updates. > I've updated the tests which were converted to be negative: > InheritAgent0100, InheritAgent1000 and InheritAgent1100 > These are the only tests that needed update with new expectations. I've updated the **@bug** in the tests to include this bug ID. All the comments from Mandy have been addressed now. ------------- PR: https://git.openjdk.java.net/jdk/pull/1694
