On Mon, 4 Jan 2021 16:29:20 GMT, Coleen Phillimore <[email protected]> wrote:
>> A small robustness fix in ThreadsSMRSupport::print_info_on() to reduce the >> likelihood of crashes during error reporting. Uses Threads_lock->try_lock() >> for safety and restricts some reporting to when the Threads_lock has been >> acquired (depends on JDK-8256383). Uses a ThreadsListHandle to make >> the current ThreadsList safe for reporting (depends on JDK-8258284). Also >> detects when the system ThreadsList (_java_thread_list) has changed and >> will warn that some of the reported info may now be stale. >> >> Two existing tests have been updated to reflect the use of a >> ThreadsListHandle >> in ThreadsSMRSupport::print_info_on(). Mach5 Tier[1-6] testing has no >> regressions. > > Looks good. One comment. Also, ha ha, Harold caught me today: you need to > update the copyrights! Maybe the PR/JBS title should be shortened to "ThreadsListHandleInErrorHandlingTest.java fails in printing all threads" for conciseness and to make GitHub happy? ------------- PR: https://git.openjdk.java.net/jdk/pull/1891
