On Tue, 5 Jan 2021 22:26:11 GMT, Coleen Phillimore <[email protected]> wrote:
>> Coleen, the function `ClassLoader::add_to_boot_append_entries` is also >> called from `ClassLoader::update_class_path_entry_list` and >> `ClassLoaderExt::append_boot_classpath`. It is not clear why the >> `Bootclasspath_lock` is not used for sync in these contexts. Could you >> consider to move this `MutexLocker` from >> `JvmtiEnv::AddToBootstrapClassLoaderSearch` to >> `ClassLoader::add_to_boot_append_entries`? > > Thanks Serguei. I was trying to decide whether to move the lock there or add > an assert that we are not multi-threaded when the lock isn't held. But it's > cleaner to just move the lock there, so I'll do that. I reran tier1 and jvmti and jdi tests. ------------- PR: https://git.openjdk.java.net/jdk/pull/1935
