On Fri, 22 Jan 2021 08:23:17 GMT, Thomas Schatzl <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Merge remote-tracking branch 'upstream/master' into JDK-8259009
>> - G1 heap summary should be shown in "Heap Parameters" window on HSDB
>
> I would prefer to make the order of parameters uniform in
> `printG1HeapSummary(G1CollectedHeap g1h, PrintStream tty) {` too. I.e. there
> does not seem to be a reason to have only this function have `tty` as second
> parameter.
@tschatzl Thanks for the comment! I fixed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1911