On Fri, 5 Feb 2021 19:58:42 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Dear @plummercj, >> >>> `--dumpfile` and `--gz` can only be used with `--binaryheap`. That should >>> be made clear in the help text. >> >> I added indentation for these two sub-options. >> >>> * SA's `jhsdb jmap --binaryheap` (which uses JMap.java with >>> `-heap:format=b`) >>> * SA's clhsdb `dumpheap` command (which also uses JMap.java with >>> `-heap:format=b`) >>> * executing SA's `sun/jvm/hotspot/tools/JMap` class directly >>> * `jmap -dump` command (Uses Attach API's `heapdump` command, which uses >>> hotspot `HeapDump` class) >>> * `GC.heap_dump` dcmd, which also uses the hotspot `HeapDumper` class >> All 5 commands help message have been tested. > > Hi Lin, > Thank you for the update with requested changes. > Please, note, my suggestion was rough and still needs to be tested/checked > for potential bugs. :) > I'll look at changes in other files as well. > Thanks, > Serguei > I think new PR can be created for adding `format=x` to `clhsdb dumpheap` and > `jhsdb jmap`. And maybe new CSR is required? You can do that if you'd like. I'm not sure how important format=x is. ------------- PR: https://git.openjdk.java.net/jdk/pull/1712
