On Wed, 10 Feb 2021 04:04:56 GMT, Lin Zang <lz...@openjdk.org> wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump > > Lin Zang has updated the pull request incrementally with two additional > commits since the last revision: > > - fix indentation isue > - fix help message issue and Use ByteBuffer for integer writing Hi Lin, I'm sorry for the delay. The fix looks good to me. I have one minor request below. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java + private static byte[] genByteArrayFromInt(int integer) { . . . + private final void writeInteger(int v) { Could you, please, replace both parameters 'integer' and 'v' with something like 'val' or 'value'? Thanks, Serguei ------------- Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1712