On Wed, 3 Mar 2021 13:28:21 GMT, Lutz Schmidt <[email protected]> wrote:

>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of 
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow 
>> probability way out (> 500 years in case of a 1 GHz counter update 
>> frequency).
>> - counters for individual methods are interpreted as (unsigned int), in 
>> contrast to their declaration as int. This gives us a factor of two before 
>> the counters overflow.
>> - as a special case, "compiled_invocation_counter" is retyped as long, 
>> because it has a higher update frequency than other counters.
>> - before/after sample output is attached to the bug description. 
>> 
>> Thank you!
>> Lutz
>
> Lutz Schmidt has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   revert copyright change to get rid of unchanged file

This looks good to me.

-------------

Marked as reviewed by iveresov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2511

Reply via email to