On Wed, 3 Mar 2021 20:12:55 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed 
>> out
>
> The fix is fairly big and could use some explaining. Can you provide a bit 
> more detail on what the bug is? In the CR you mention it is due to the 
> combination of a very large array and the segmented heap dump support, but 
> don't really explain what the actual bug is. You can add this detail to the 
> CR rather than here.  Also can explain your solution, especially this new 
> `writeThrough` mode? Thanks.

Hi Chris,

Thanks for your review, I found there is a potential risk for huge object 
dumping with this PR, I would work out an update and then add the explaination 
in the CR.
Thanks!

BRs,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/2803

Reply via email to