On Thu, 4 Mar 2021 07:32:26 GMT, Chris Plummer <[email protected]> wrote:
>> BTW, referring back to the change to have attach handle pids and debug
>> servernames, and the concern about a host having a numeric name, we already
>> have code that assumes we don't have to deal with this in Tools.java. I just
>> stumbled across this:
>>
>> try {
>> pid = Integer.parseInt(args[0]);
>> debugeeType = DEBUGEE_PID;
>> } catch (NumberFormatException e) {
>> // try remote server
>> remoteServer = args[0];
>> debugeeType = DEBUGEE_REMOTE;
>> }
>
> I think the changes look good now. Please create a CSR and then we can finish
> the review of this PR.
I filed CSR and finalized it: https://bugs.openjdk.java.net/browse/JDK-8263005
> BTW, referring back to the change to have attach handle pids and debug
> servernames, and the concern about a host having a numeric name, we already
> have code that assumes we don't have to deal with this in Tools.java. I just
> stumbled across this:
Thanks! I felt confident for current PR :)
-------------
PR: https://git.openjdk.java.net/jdk/pull/2773
