On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev <iignat...@openjdk.org> wrote:
> Hi all, > > could you please review this dull patch that replaces `ClassFileInstaller` w/ > `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to > ensure we won't get split testlibrary, and removes > `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used). > > from JBS: >> after JDK-8263412, we might (again) encounter NCDFE b/c parts of >> testlibraries aren't on the classpath. this happens when jtreg builds >> `jdk.test.lib.helpers.ClassFileInstaller` as a part of test-specific code, >> but `ClassFileInstaller` as part of shared testibrary directory in one test, >> when in the following test, jtreg sees `ClassFileInstaller` in the shared >> directory, hence javac won't recompile it/its dependencies, but in runtime >> `jdk.test.lib.helpers.ClassFileInstaller` is nowhere to be found, hence we >> get NCDFE. > > testing: > - [x] `grep ' ClassFileInstaller[^.]` > - [ ] tier1-3 > > Thanks, > -- Igor This pull request has now been integrated. Changeset: a7aba2b6 Author: Igor Ignatyev <iignat...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/a7aba2b6 Stats: 1738 lines in 867 files changed: 2 ins; 67 del; 1669 mod 8263549: 8263412 can cause jtreg testlibrary split Reviewed-by: iklam, dcubed ------------- PR: https://git.openjdk.java.net/jdk/pull/2985
