On Wed, 10 Mar 2021 04:22:07 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix white space in CDS.java > > src/java.base/share/classes/jdk/internal/misc/CDS.java line 278: > >> 276: dumpDynamicArchive(archiveFile); >> 277: } >> 278: } > > I think we should have some error checks and clean up: > > - Remove the classlist file > - Check if if the process exit status is 0 > - Remove the JSA file first, then try to dump it, and check if the file > exists afterwards. If not, report the error. (For both dynamic and static > dumps)
The classlist file is not deleted after the dump has finished. ------------- PR: https://git.openjdk.java.net/jdk/pull/2737