On Wed, 31 Mar 2021 16:07:56 GMT, Andrey Turbanov <github.com+741251+turban...@openjdk.org> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java >> line 887: >> >>> 885: protected String genMultPCHref(String pcs) { >>> 886: String buf = genBaseHref() + "pc_multiple=" + pcs; >>> 887: return buf; >> >> This is like VMVersionMismatchException.java above, where as it is reduced >> to two lines, we may as well reduce it to one line with: >> return genBaseHref() + ..etc... >> >> With these two minor changes, I think this looks good. > > done Thanks - just a nit, looks like an extra space means "return genBaseHref() ..etc.." is not aligned. ------------- PR: https://git.openjdk.java.net/jdk/pull/3275