On Tue, 30 Mar 2021 03:44:26 GMT, David Holmes <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> relax flag attributions (ala JDK-7123237)
>
> src/hotspot/share/services/writeableFlags.cpp line 250:
>
>> 248: if (err == JVMFlag::SUCCESS) {
>> 249: assert(value == NULL, "old value is freed automatically and not
>> returned");
>> 250: }
>
> The whole block should be ifdef DEBUG.
Since this whole block can be optimized out by the C compiler in product
builds, I'd rather leave out the `#ifdef` to avoid clutter.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3254
