On Tue, 6 Apr 2021 00:56:08 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> test/hotspot/jtreg/serviceability/sa/sadebugd/DebugdRmidTest.java line 51:
>>
>>> 49: JDKToolLauncher rmidLauncher =
>>> JDKToolLauncher.createUsingTestJDK("rmid");
>>> 50:
>>> rmidLauncher.addToolArg("-J-Dsun.rmi.activation.execPolicy=none");
>>> 51: rmidLauncher.addToolArg("-J--add-modules=jdk.hotspot.agent");
>>
>> Is this really needed? Although SA will be using rmid, I don't understand
>> why rmid needs to know about SA.
>
> They are needed.
>
> If we don't give `execPolicy=none`, we can see warning on console.
> SA code would run on rmid, so we need to add module.
I was actually just referring to `--add-modules`, but github added a few lines
before the one I selected.
I guess I'm not fully understanding what `rmid` is for in this context, and how
it relates to the `rmiregistry` command. I thought it was starting the
registry, but that does not seem to be it's primary purpose (maybe it starts it
as a side affect). Also, it is deprecated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3233
