On Wed, 31 Mar 2021 05:53:43 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - 8257831: Suspend with handshake (review baseline) > > src/hotspot/share/runtime/handshake.hpp line 148: > >> 146: // Called from the async handshake (the trap) >> 147: // to stop a thread from continuing executing when suspended. >> 148: void suspend_in_handshake(); > > I'm finding the terminology very confusing here: handshake_suspend versus > suspend_in_handshake ? It isn't at all clear which method is used in which > part of the protocol. The same goes for the different closures. Fixing ------------- PR: https://git.openjdk.java.net/jdk/pull/3191
