On Mon, 12 Apr 2021 06:42:47 GMT, Robbin Ehn <[email protected]> wrote:
> > > Technically you are correct. > I have tested to remove this is previously version and all tests passes fine. > The reason I kept it is because the suspender have identified a thread for > suspension and deemed it suspendable, so we play nice. > To know why suspend failed the suspender must check if thread is exiting > after a failed suspend. (originally I had a bug here which caused me to > wrongfully introduce this from the beginning) Thanks for the explanation. As I understand you want to be fault tolerant towards somewhat sloppy agents. That's of course ok. It should be explained in a comment though. > I'll remove it, since it simplifies the code and David's comments about this > code is now out-of-line can be fixed. Also it does not eliminate the race as far as I can tell. ------------- PR: https://git.openjdk.java.net/jdk/pull/3191
