On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The test actually failed starting from jdk13, but the error is masked by > JDK-8264667 (and shell part of the test didn't verify result of the java > execution) > The fix: > - updates JvmtiClassFileReconstituter to add attributes in the same order as > javac does > - makes the test java instead of shell > - added workaround for JDK-8264667 > - test code is ready to ignore order of attributes test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java line 152: > 150: // directory so there is no conflict with the file > 151: // in the test classes directory. > 152: String resourceName = fTargetClassName + ".class"; This name can be defined out of methods `originalTargetClassFile` and `transformClassFile`. The method name `transformClassFile` is confusing. I'd suggest to rename it to `transformedClassFile` or `modifiedClassFile`. Also, the name `originalTargetClassFile` can be shortened to `originalClassFile`. ------------- PR: https://git.openjdk.java.net/jdk/pull/3426
