> Hi, > > Could I have a review of fix that removes the use of "=" together with > -XX:StartFlightRecording and -XX:FlightRecorderOptions. It's been possible to > use "-XX:StartFlightRecording:" and "-XX:FlightRecorderOption:" since JFR was > introduced into OpenJDK (JDK 11), so this is not a change of the > specification, just an update to make the use consistent in tests, comments, > documentation etc. > > I also removed the use of -XX:+FlightRecorder, which is not needed, and has > been deprecated since JDK 13. > > Testing: jdk/jdk/jfr, tier 1-4. > > Thanks > Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Replace '=' in jfrOptionsSet.cpp ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3561/files - new: https://git.openjdk.java.net/jdk/pull/3561/files/4ce08939..138bac16 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3561&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3561&range=00-01 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/3561.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3561/head:pull/3561 PR: https://git.openjdk.java.net/jdk/pull/3561
