On Wed, 28 Apr 2021 06:38:57 GMT, Wang Huang <whu...@openjdk.org> wrote:
> Dear All, > I find a memory leak in `appendBootClassPath()` > https://github.com/openjdk/jdk/blob/75a2354dc276e107d64516d20fc72bc7ef3d5f86/src/java.instrument/share/native/libinstrument/InvocationAdapter.c#L950 > * we malloc `resolved` from resolve(parent, path) > * we use `resolved` in line 951 > * we don't free() this memory after using. > > I think we can fix this bug by adding a free() after line 951 as my commit. > Thank you for your review. Any suggestion is welcome. > > Yours , > Wang Huang This pull request has now been integrated. Changeset: aa90df6f Author: Wang Huang <whu...@openjdk.org> Committer: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/aa90df6f51940a73f9aa078a32768855c8568034 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8266187: Memory leak in appendBootClassPath() Co-authored-by: Wang Huang <whu...@openjdk.org> Co-authored-by: Sun Jianye <sunjia...@huawei.com> Reviewed-by: kevinw, mli, alanb ------------- PR: https://git.openjdk.java.net/jdk/pull/3751
