On Tue, 11 May 2021 13:37:32 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass(). >> The change removes dAC relevant code and changes a lot of tests. Many of >> the changed tests need renaming. I hope to do this in a follow up RFE. >> Some of the tests were modified to use hidden classes, others were deleted >> because either similar hidden classes tests already exist or they tested dAC >> specific functionality, such as host classes. >> >> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, >> and Mach5 tiers 3-7 on Linux x64. >> >> Thanks, Harold > > test/jdk/java/lang/Class/GetModuleTest.java line 42: > >> 40: import static org.testng.Assert.*; >> 41: >> 42: public class GetModuleTest { > > testGetModuleOnVMAnonymousClass is the only test here that uses ASM so you > can remove the imports as part of the removal. Can you check test/jdkjava/lang/Class/attributes/ClassAttributesTest.java? It may minimally need a comment to be updated. That's the only additional test that I could find in test/jdk. ------------- PR: https://git.openjdk.java.net/jdk/pull/3974