On Wed, 28 Apr 2021 13:03:15 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unnecessary "@library /test/lib". > > HI Dan, > > Some minor comments, but to be frank I have no idea what this test is > actually doing - sorry. > > Cheers, > David @dholmes-ora also sent the comment in email but it didn't seem to show up in this PR: > Hmmm... this is a legacy style/approach that is not necessary any more. > If the test fails it should throw an exception from the main thread and > that will produce a non-zero exit value. I think seeing this legacy style in > new tests will just confuse people. I agree. In particular this legacy style approach with exit_delta == 95 is for VMTestbase tests and this new test is not part of the VMTestbase test suite. I'm fixing this. ------------- PR: https://git.openjdk.java.net/jdk/pull/3478
