On Thu, 13 May 2021 05:57:55 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes for Dan
>
> src/hotspot/share/runtime/objectMonitor.cpp line 435:
>
>> 433: EnterI(current);
>> 434: }
>> 435: if (!eos.om_op_done()) {
>
> I find this API too generic. I'd much rather see:
>
> if (!eos.exited()) {
> assert ...
> break;
> }
Fixed
> src/hotspot/share/runtime/objectMonitor.hpp line 309:
>
>> 307: protected:
>> 308: ObjectMonitor* _om;
>> 309: bool _om_op_done;
>
> Please rename to _exited - we know what the "op" is so no need to use generic
> terminology.
Fixed
> src/hotspot/share/runtime/objectMonitor.hpp line 313:
>
>> 311: ExitOnSuspend(ObjectMonitor* om) : _om(om), _om_op_done(false) {}
>> 312: void operator()(JavaThread* current);
>> 313: bool om_op_done() { return _om_op_done; }
>
> please rename to exited()
Fixed
> src/hotspot/share/runtime/objectMonitor.hpp line 315:
>
>> 313: bool om_op_done() { return _om_op_done; }
>> 314: };
>> 315: class ClearSuccOnSuspend : public ExitOnSuspend {
>
> I don't see why there is any relationship between these two. You don't
> clear-succ and exit.
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3875
