On Thu, 10 Jun 2021 10:26:46 GMT, Igor Ignatyev <[email protected]> wrote:

> Hi all,
> 
> could you please review this small fix for 
> `serviceability/logging/TestFullNames.java` test?
> from JBS:
>> serviceability/logging/TestFullNames.java test contains two test cases: 
>> specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove 
>> the file, hence its 2nd test case doesn't really test much.
> 
> the patch simply calls `File::delete` inside the loop and verifies that the 
> file doesn't exist at the beginning of each iteration.
> 
> testing: `serviceability/logging/TestFullNames.java` on 
> `{linux,windows,macosx}-x64`
> 
> Thanks,
> -- Igor

Thanks, Serguei!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4461

Reply via email to