On Tue, 22 Jun 2021 10:53:06 GMT, Guoxiong Li <[email protected]> wrote:
>> Hi all, >> >> Considering the consistency of `JavaThread` and other threads, such as >> WorkerThread and CompilerThread, `JavaThread` could use a method named >> `cast` to replace the method `Thread::as_Java_thread()`. It can reduce the >> Thread's knowledge about the subtypes. >> >> This patch removes two methods, `JavaThread* Thread::as_Java_thread()` and >> `const JavaThread* Thread::as_Java_thread() const`, of the class `Thread` >> and adds two static methods, `JavaThread* cast(Thread* t)` and `const >> JavaThread* cast(const Thread* t)`, to the class `JavaThread`. >> Correspondingly, the code of the method `JavaThread::current()` need to be >> adjusted and many places where the method `Thread::as_Java_thread()` is used >> need to use `JavaThread::cast` instead. >> >> Test: >> tier1 passed locally. >> >> Thanks for taking the time to review. >> >> Best Regards, >> -- Guoxiong > > Guoxiong Li has updated the pull request incrementally with one additional > commit since the last revision: > > Remove inline specifier Updates look fine. Thanks, David ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4546
