On Tue, 6 Jul 2021 02:55:37 GMT, Lin Zang <[email protected]> wrote:

> The current implementation of hprof Reader for testing always prompts "Can 
> not decompress the compressed hprof file" when there is error for testing 
> gzipped heap dump. This is inaccurate if the gzipped file was decompressed 
> successfully but the hprof file format is incorrect. So the inaccurate error 
> message could be misleading for issue analysis.
> 
> This trivial PR refine the error message by simply print "Can not get stack 
> trace from the compressed hprof file", the underlying exception from 
> GZIPInputStream() or HprofReader() would give accurate error info.

This pull request has now been integrated.

Changeset: 4fbcce11
Author:    Lin Zang <[email protected]>
Committer: David Holmes <[email protected]>
URL:       
https://git.openjdk.java.net/jdk/commit/4fbcce119b1736455cb74d0a585097eca617593c
Stats:     12 lines in 1 file changed: 7 ins; 2 del; 3 mod

8269886: Inaccurate error message for compressed hprof test

Reviewed-by: dholmes, cjplummer

-------------

PR: https://git.openjdk.java.net/jdk/pull/4685

Reply via email to