On 3/08/2021 2:25 am, Igor Ignatyev wrote:
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev <iignat...@openjdk.org> wrote:
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the following substitutions:
- `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
- `s/sun.hotspot.parser/jdk.test.whitebox.parser/g`
- `s/sun.hotspot.cpuinfo/jdk.test.whitebox.cpuinfo/g`
- `s/sun.hotspot.code/jdk.test.whitebox.code/g`
- `s/sun.hotspot.gc/jdk.test.whitebox.gc/g`
- `s/sun.hotspot.WhiteBox/jdk.test.whitebox.WhiteBox/g`
testing: tier1-4
Thanks,
-- Igor
Igor Ignatyev has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains 12 new commits
since the last revision:
- fixed ctw build
- updated runtime/cds/appcds/JarBuilder to copy j.t.w.WhiteBox's inner class
- updated requires.VMProps
- updated TEST.ROOT
- adjusted hotspot source
- added test
- moved and adjusted WhiteBox tests (test/lib-test/sun/hotspot/whitebox)
- updated ClassFileInstaller to copy j.t.w.WhiteBox's inner class
- removed sun/hotspot/parser/DiagnosticCommand
- deprecated sun/hotspot classes
disallowed s.h.WhiteBox w/ security manager
- ... and 2 more:
https://git.openjdk.java.net/jdk17/compare/8f12f2cf...237e8860
Hi David,
This set of changes seems much more manageable to me.
thank you for your review, David.
Not sure about the new deprecation warnings for the old WB classes .. might
that not itself trigger some failures? If not then I don't see how the
deprecation warnings help with transitioning to the new WB class?
the deprecation warnings (hopefully) will help people not to forget that they
should use the new WB class in new tests.
If the test passes it is unlikely people will actually notice these in
the jtr file - and even if they see them they may just ignore them
thinking they are similar to all the security manager warnings that we
ignore.
But as long as it does no harm.
Cheers,
David
Thanks,
-- Igor
Hi Jie,
Shall we also update the copyright year like
test/lib/sun/hotspot/cpuinfo/CPUInfo.java?
we most certainly shall, just pushed the commit that updates the copyright
years in the touched files.
Cheers,
-- Igor
-------------
PR: https://git.openjdk.java.net/jdk17/pull/290
