On Sat, 17 Jul 2021 00:38:44 GMT, Alex Menkov <amen...@openjdk.org> wrote:

> The fix updates the tests to use dynamic port launching debuggee and get the 
> listening port from the debugee output

test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attachnosuspend/attachnosuspend001.java
 line 101:

> 99:         String cmd = java
> 100:                 + " -Xdebug -Xnoagent 
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=0"
> 101:                 + " " + DEBUGEE_CLASS;

You've lost logging of the port you end up listening on. Is the dynamically 
discovered listening port logged somewhere else?

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 330:

> 328:      */
> 329:     public void redirectStdout(Log log, String prefix) {
> 330:         redirectStdout(log, prefix, null);

Is there a reason to still support passing in the prefix even though it is 
ignored. Seems that could be confusing to someone looking at the caller code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4817

Reply via email to