On Mon, 2 Aug 2021 04:31:55 GMT, David Holmes <[email protected]> wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional commits since the last revision:
>>
>> - Merge branch 'pull/4948' into JDK-8271514
>> - Merge branch 'pull/4948' into JDK-8271514
>> - 8271514: support JFR use of new ThreadsList::Iterator
>
> src/hotspot/share/jfr/utilities/jfrThreadIterator.hpp line 50:
>
>> 48: class JfrJavaThreadIteratorAdapter {
>> 49: private:
>> 50: ThreadsListHandle _tlist;
>
> Why do we need to store this?
>
> It looks very suspiocious to have a member that is a stackObj, in a class
> that is not itself a stackObj. ??
The _tlist is used locally in JfrJavaThreadIteratorAdapter constructor only, so
it is possible to get rid of it for the price of complicating the constructor a
little bit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4949
