On Wed, 18 Aug 2021 12:25:45 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
>> Please review this small fix for JDK-8272124. The fix puts a limit of 3 >> when splitting self cgroup lines by ':' so that Cgroup paths won't get >> truncated if they contain embedded ':'s. For example, an entry of >> "11:memory:/user.sli:ce" in a /proc/self/cgroup file will now result in a >> Cgroup path of "/user.sli:ce" instead of "/user.sli". >> >> The fix was tested with Mach5 tiers 1 and 2, and Mach5 tiers 3-5 on Linux >> x64 and Linux aarch64. >> >> Thanks, Harold > > Harold Seigel has updated the pull request incrementally with one additional > commit since the last revision: > > add mountinfo containing colongs to test Changes requested by sgehwolf (Reviewer). test/jdk/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java line 207: > 205: // `hierarchy-ID:controller-list:cgroup-path`. This cgroup-path > intentionally > 206: // contains a colon to ensure that the correct path is being > extracted by the > 207: // login in CgroupSubsystemFactory. s/login/logic ------------- PR: https://git.openjdk.java.net/jdk/pull/5127
