On 28/08/2021 18:59, Jakob Cornell wrote:
Hi Alan,
Yes, this is just the empty command handling. I am personally
interested in Jline integration, but Chris is skeptical about the
review prospects for that, and since he's been helping me through the
process I've limited the present work. Maybe now that the patch for
empty command handling is done (for now) I'll look into prototyping
Jline integration. I believe that would need a separate JBS ticket,
and a separate PR once ready, and we probably want to kick off a new
thread here since the present subject lines don't mention Jline.
Okay, I just checking as improving the line editing experience would go
a long way to improve the overall usability and bring it closer to the
jshell experience. At the same time, most developers will use IDEs and
other tools for debugging and probably only rarely use jdb. Aside from
the JDK tests, the number of direct users of jdb may be small, perhaps
only as a simple tool for debugging/diagnostics when accessing remote
systems. So not opposed to just focusing on have a way for empty lines
repeat the command, I'm just pointing out that there are larger
usability issues.
As requires JBS issues, PR, and CSRs, then I view the currently
discussion as mostly in exploratory phase right now. The extent of the
changes with the prototypes will help building consensus on a direction.
-Alan.
