On Wed, 6 Oct 2021 04:17:16 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a helper class to facilitate checking archive > > src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c line 369: > >> 367: >> 368: // check file magic >> 369: if (header._generic_header._magic != CDS_ARCHIVE_MAGIC) { > > Use `header.magic()` instead?
header is a structure of CDSFileMapHeaderBase, unless we cast it to FileMapHeader. ------------- PR: https://git.openjdk.java.net/jdk/pull/5768