On Tue, 2 Nov 2021 19:25:40 GMT, Leo Korinth <lkori...@openjdk.org> wrote:
>> HeapDumper does a lot of unneeded casts. Some arguments should be const. >> Headers are not correctly sorted. Comment about identifier size on Windows >> and Solaris is not true. >> >> First I cleaned up casting in the "union casting", but then I decided it was >> better to create a temporary bit_cast that we can use until we get the >> proper one in c++20. > > Leo Korinth has updated the pull request incrementally with one additional > commit since the last revision: > > restart failed github tests Looks good! Thanks, Harold ------------- Marked as reviewed by hseigel (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6211
