On Fri, 5 Nov 2021 14:14:43 GMT, Leo Korinth <lkori...@openjdk.org> wrote:
>> Use override specifier in HeapDumper. It is safer.
>
> Leo Korinth has updated the pull request incrementally with one additional
> commit since the last revision:
>
> restart failed github tests
Hi Leo, seems fine.
..Thomas
src/hotspot/share/services/heapDumper.cpp line 626:
> 624: void deactivate() override { flush();
> _backend.deactivate(); }
> 625: // Get the backend pointer, used by parallel dump writer.
> 626: CompressionBackend* backend_ptr() { return &_backend; }
Unrelated, but could be a const method, no?
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6274
