On Fri, 12 Nov 2021 15:08:24 GMT, Patricio Chilano Mateo 
<pchilanom...@openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add _is_running initialization.
>
> src/hotspot/share/jfr/dcmd/jfrDcmds.cpp line 181:
> 
>> 179:   JNIHandleMark jni_handle_management(THREAD);
>> 180: 
>> 181:   DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_vm(THREAD));
> 
> This method will call into Java below which already checks the thread is in 
> vm so maybe this is not necessary. Even construct_dcmd_instance() has that 
> assert.

You're right, it's doubly redundant.  I'll remove it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6336

Reply via email to