On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API spec for
>> JEP 421. It also updates the relevant @SuppressWarning annotations.
>>
>> The CSR has been approved.
>> An automated test build+test run passes cleanly (FWIW :D ).
>
> Brent Christian has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 33 commits:
>
> - Merge branch 'master' into 8276447
> - Merge branch 'master' into 8276447
> - merge
> - @SuppressWarnings(removal) in Windows CKey.java
> - Add jls tag to runFinalization methods
> - Update wording of Object.finalize, new paragraph is now bold
> - update Object.finalize javadoc
> - update Object.finalize JavaDoc and @deprecated tag
> - Update Object.finalize deprecation message
> - Indicate that runFinalizers does nothing if finalization is disabled or
> removed
> - ... and 23 more:
> https://git.openjdk.java.net/jdk/compare/0dfb3a70...8cde0674
Marked as reviewed by smarks (Reviewer).
src/jdk.jconsole/share/classes/sun/tools/jconsole/SummaryTab.java line 116:
> 114: StringBuilder buf;
> 115:
> 116: @SuppressWarnings("deprecation")
Item for future cleanup: refactor the call to
`getObjectPendingFinalizationCount()` at line 219 (!) into a local variable
declaration, and then move the warnings suppression to that declaration. This
reduces the scope of warnings suppression.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6465
