On Thu, 16 Dec 2021 20:20:41 GMT, Evgeny Nikitin <eniki...@openjdk.org> wrote:
>> This PR contains a relatively simple test which verifies that JVMTI-agents
>> are correctly informed about exceptions caught in C2-compiled code. The
>> 8269574 introduces pre-allocated exceptions in some paths, so the test tries
>> to produce a number of various exceptions and check that provided small
>> JVMTI agent got notified about all of them.
>
> Evgeny Nikitin has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains six additional
> commits since the last revision:
>
> - Get rid of while-breaks
> - Add JIT requirements
> - Remove explicit type specifiers for own class static calls
> - Remove redundant build directive
> - Merge branch 'master' into JDK-8274982/public
> - 8274982: Add a test for 8269574.
Marked as reviewed by lmesnik (Reviewer).
test/hotspot/jtreg/compiler/jvmti/libTriggerBuiltinExceptions.cpp line 79:
> 77: } while (false);
> 78:
> 79: return (result == JNI_OK) || (result == JVMTI_ERROR_NONE) ? JNI_OK :
> JNI_ERR;
Seems (result == JNI_OK) || (result == JVMTI_ERROR_NONE) should be (result ==
JNI_OK) && (result == JVMTI_ERROR_NONE).
Really, I think it would be better to replace
do {
...
break;
..
} while (false)
with multiply return.
It makes logic simpler and style compliant to all jvmti tests.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5889
