On Fri, 17 Dec 2021 13:44:01 GMT, Harold Seigel <[email protected]> wrote:
>> Please review this fix for JDK-8225093 to set the default value of property
>> jdk.boot.class.path.append to NULL instead of "". This fix was tested by
>> running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5
>> on Linux x64. The fix was also tested by running the agent.c example in
>> JDK-8224791.
>>
>> Thanks! Harold
>
> Harold Seigel has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix test
Marked as reviewed by alanb (Reviewer).
test/hotspot/jtreg/runtime/BootClassAppendProp/libGetBootClassPathAppendProp.c
line 53:
> 51: if (err != JVMTI_ERROR_NONE) {
> 52: return (*env)->NewStringUTF(env, "wrong error code");
> 53: }
For diagnosability it may be helpful to have this native method throw an
exception with the JVMTI error code or alternatively have the return String
include the error code rather than a generic message "wrong error code".
-------------
PR: https://git.openjdk.java.net/jdk/pull/6868
