On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead, 
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream and DataInput is an irrelevant 
> formatting artefact and thus can be removed.
> - `&#39;` is an apostrophe, which does not require to be encoded.

Overall this looks good, thanks for the clean up :-)

A few comments below

src/java.base/share/classes/java/io/DataInput.java line 496:

> 494:      * ceases. If the character {@code '\r'}
> 495:      * is encountered, it is discarded and, if
> 496:      * the following byte converts to the

The above is a bit confusing as it reads(same in ImageInputStream.java).  I 
think that that can be looked at later.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7063

Reply via email to