On Tue, 18 Jan 2022 18:33:29 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

> While working on JDK-8280003, I noticed that 
> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays 
> with more than 1-byte size elements, and no large arrays (past 4G limit) are 
> tested either. It would be better to add those test cases. 
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, affected test still passes
>  - [x] Linux x86_32 fastdebug, affected test still passes
>  - [ ] Linux AArch64 fastdebug, affected test still passes
>  - [ ] Linux PPC64 fastdebug, affected test still passes

test/jdk/java/lang/instrument/GetObjectSizeIntrinsicsTest.java line 326:

> 324: 
> 325:     public static void main(String[] args)throws Throwable {
> 326:         new GetObjectSizeIntrinsicsTest(args[0], (args.length >= 2 ? 
> args[1] : "")).runTest();

Shouldn't this be `args.length == 2`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7132

Reply via email to