The test is failing to find certain types in the scanoops output when run with 
-Xcomp. This is happening in the loom repo. The reason it is happening there is 
because loom introduced a full GC during codecache sweeping. The test only runs 
scanoops on the eden gen, and the full GC is causing objects of certain 
expected types to no longer be present in the eden gen. The fix is to also 
check the old gen.

The logic of the test had to be reworked a bit to accomplish checking the 
output of two scanoops commands together. It was relying on the ClhsdbLauncher 
class to check the output for expected strings, but in this case we need to 
accumulate the output of the two scanoops commands and check the combined 
output for the expected strings, so now the checking is done directly by the 
test and not by ClhsdbLauncher.

I'm choosing to fix this in the jdk repo rather than the loom repo since it is 
a latent bug that theoretically could occur even without the loom changes, and 
also to help reduce the amount of changes to be reviewed when loom is 
integrated into jdk.

-------------

Commit messages:
 - Minor changes to comments.
 - Check both eden and old gen for expected types.

Changes: https://git.openjdk.java.net/jdk/pull/7295/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7295&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8279662
  Stats: 40 lines in 1 file changed: 22 ins; 2 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7295.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7295/head:pull/7295

PR: https://git.openjdk.java.net/jdk/pull/7295

Reply via email to