On Wed, 2 Feb 2022 18:58:23 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>>> Are you still hitting the assert in fillInvokeRequest()? I'm not sure why 
>>> it would ever not be NULL there. It's probably worth investigating some 
>>> more. Otherwise you need to remove the assert, and possibly still have a 
>>> leak.
>> 
>> No, the latest version seems good and passes tier1-3 and customer confirmed 
>> that it fixes the memory leak.
>
> Ok. I think I prefer you to free the memory after calling 
> `deleteGlobalArgumentRefs()` since `deleteGlobalArgumentRefs()` is really all 
> about releasing JNI global refs, not freeing other allocated memory.

Ok, I've moved it back to after the call to deleteGlobalArgumentRefs().

-------------

PR: https://git.openjdk.java.net/jdk/pull/7306

Reply via email to