On Wed, 19 Jan 2022 01:17:21 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   moved deprecated flag to deprecated section in manpages
>
> src/java.base/share/man/java.1 line 4001:
> 
>> 3999: .TP
>> 4000: .B \f[CB]\-XX:+ExtendedDTraceProbes\f[R]
>> 4001: Deprecated. Use combination of these flags instead: 
>> -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes, -XX:+DTraceMonitorProbes
> 
> Delete "Deprecated" as we are in the deprecated options section.
> 
> The wording also needs updating as per the warning text ... though that might 
> read a little odd here so I suggest a tweak:
> 
> Use the combination of -XX:+DTraceMethodProbes, -XX:+DTraceAllocProbes and 
> -XX:+DTraceMonitorProbes instead of this deprecated flag.
> 
> 
> I would also move that new text to the end, so we still describe the flag 
> first (otherwise it again reads a little odd.)
> 
> We will also need to add those flags to the "ADVANCED SERVICEABILITY OPTIONS 
> FOR JAVA" section.

@dholmes-ora thanks for the suggestions, I implemented them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7110

Reply via email to