On Mon, 14 Feb 2022 13:05:52 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> ClassLoaderDataGraph::classes_do description says:
>> // Walking classes through the ClassLoaderDataGraph include array classes.
>> So do_load_class callback should not dump arrays for the classes and dumper 
>> doesn't need to call Universe::basic_type_classes_do (array classes for 
>> primitive types are also reported by ClassLoaderDataGraph::classes_do)
>
> Alex Menkov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reworked do_class_dump

The changes look good. Have you verified that after your most recent changes 
you get the same sized hprof file as with your initial changes?

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7384

Reply via email to