On Wed, 23 Feb 2022 15:52:31 GMT, Johannes Bechberger <d...@openjdk.java.net> 
wrote:

>> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using 
>> the newly introduced method `JavaThread::thread_from_jni_environment`.
>
> Johannes Bechberger has refreshed the contents of this pull request, and 
> previous commits have been removed. The incremental views will show 
> differences compared to the previous content of the PR. The pull request 
> contains one new commit since the last revision:
> 
>   Add changes by David Holmes

Hi Johannes,

Your original changes need removing again.

Thanks,
David

src/hotspot/share/runtime/thread.hpp line 1325:

> 1323:   // external JNI entry points where the JNIEnv is passed into the VM.
> 1324:   // Does not return null, check 
> is_thread_from_jni_environment_termminated()
> 1325:   // if you are not sure that it is not.

Needs deleting.

src/hotspot/share/runtime/thread.hpp line 1354:

> 1352:     return current->is_terminated();
> 1353:   }
> 1354: 

Needs deleting.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7559

Reply via email to