On Mon, 28 Feb 2022 18:49:05 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds >> the test that exercises the metaspace allocation paths. >> >> Requires [JDK-8282172](https://bugs.openjdk.java.net/browse/JDK-8282172) to >> pass cleanly in fastdebug mode. >> >> Additional testing: >> - [x] New test on Linux x86_64 fastdebug >> - [x] New test on Linux x86_64 release >> - [x] New test with >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149) reverted >> fails on Linux x86_64 release > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Fix copyright Changes requested by lmesnik (Reviewer). test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java line 35: > 33: */ > 34: > 35: package serviceability.jvmti.SetBreakpoint; The serviceability tests don't use packages. The default package is used. Please remove it to be consistent. test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c line 2: > 1: /* > 2: * Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights > reserved. Shouldn't it be just 2022? test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c line 35: > 33: void JNICALL classprepare(jvmtiEnv* jvmti_env, JNIEnv* jni_env, jthread > thread, jclass klass) { > 34: char* buf; > 35: (*jvmti)->GetClassSignature(jvmti, klass, &buf, NULL); It is required to check jvmti error status for every function. So test fails early. There is no common library so far so you could just copy-paste 'check_jvmti_status' from other tests. ------------- PR: https://git.openjdk.java.net/jdk/pull/7554
