On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie <[email protected]> wrote:
> I ran `codespell` on hotspot, and accepted those changes where it indeed
> discovered real typos.
>
> You'd be surprised over the many implementions of instrinsics and other
> intructions accross all archtectures I've encounted, so for the preceding
> reason it's neccesery to sucessfully seach for exisiting typos...
Hi Magnus,
Generally looks good. Thanks for doing this extremely tedious cleanup.
A few comments/suggestions/corrections below.
And of course copyright dates need updating for Oracle copyrights.
Thanks,
David
src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp line 125:
> 123: bool LIRGenerator::can_store_as_constant(Value v, BasicType type) const {
> 124: if (type == T_SHORT || type == T_CHAR) {
> 125: // there is no immediate move of word values in assembler_i486.?pp
Dead comment as there is no such file any more.
src/hotspot/cpu/x86/macroAssembler_x86.hpp line 865:
> 863:
> 864: // 32bit can do a case table jump in one instruction but we no longer
> allow the base
> 865: // to be installed in the Address class. This jump will transfers to
> the address
transfer not transfers
src/hotspot/share/c1/c1_Runtime1.cpp line 552:
> 550: Exceptions::debug_check_abort(exception);
> 551:
> 552: // Check the stack guard pages and re-enable them if necessary and
> there is
Curious how inconsistent hyphenation rules are in English :) I would use
reenable in the same way we use mismatch.
src/hotspot/share/code/nmethod.cpp line 2906:
> 2904:
> 2905: // Compressed undisassembled disassembly format.
> 2906: // The following statuses are defined/supported:
status is the more usual self-plural - or use "status values"
src/hotspot/share/runtime/os.cpp line 644:
> 642: DEBUG_ONLY(check_crash_protection());
> 643:
> 644: // On malloc(0), implementers of malloc(3) have the choice to return
> either
I suggest "implementations of malloc..."
src/hotspot/share/runtime/task.hpp line 72:
> 70: void enroll();
> 71:
> 72: // Make the task deactivate
Should be "inactive"
src/hotspot/share/services/threadIdTable.cpp line 94:
> 92: if (!_is_initialized) {
> 93: {
> 94: // There is no obvious benefits in allowing the thread table
s/benefits/benefit/
src/hotspot/share/services/threadIdTable.cpp line 95:
> 93: {
> 94: // There is no obvious benefits in allowing the thread table
> 95: // to be concurrently populated during the initialization.
delete "the"
-------------
Changes requested by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8260
