On Fri, 29 Apr 2022 18:27:27 GMT, Mikhailo Seledtsov <[email protected]>
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/jdk/jdk/jfr/api/consumer/TestManyRecordings.java line 57:
>
>> 55: int classLoaderCount = Integer.parseInt(args[0]);
>> 56: int classCount = Integer.parseInt(args[1]);
>> 57: for (int i = 0; i <classCount; i++) {
>
> Did you mean classLoaderCount here instead of classCount? Also, please make
> sure there is a space between < and classLoaderCount.
The JFR "tests" look strange. I would expect a test called TestManyRecording to
start recordings, not created a lot of classes, similar to TestManyClasses. How
is this related to Loom? Could this be a merge gone bad?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8166
